Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122710
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-332-gdeb4194079-fm-20240319.002-gdeb41940
Precedence: bulk
MIME-Version: 1.0
Message-ID: <dd3effd7-7a53-42d8-9b00-a232563d8097@app.fastmail.com>
In-Reply-To: 
 <CAPzBOBMGKQu=3Aj6o20fYM6mKoQzbm2U8s4t34e7jAvjfEYaig@mail.gmail.com>
References: <fca97d6c-d4ec-4000-958a-72c32beb8421@app.fastmail.com>
 <a715dacb-9bac-4bea-a2bb-c623737fd81e@app.fastmail.com>
 <ce92f75c-1a59-a469-2a04-6ff391eb2361@php.net>
 <452aae1b-8929-4f08-a388-45b374d2a365@app.fastmail.com>
 <CAPzBOBMGKQu=3Aj6o20fYM6mKoQzbm2U8s4t34e7jAvjfEYaig@mail.gmail.com>
Date: Thu, 21 Mar 2024 16:11:19 +0000
To: "php internals" <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC[ Property accessor hooks, take 2
Content-Type: text/plain
From: larry@garfieldtech.com ("Larry Garfield")

On Thu, Mar 21, 2024, at 9:10 AM, Robert Landers wrote:
> Hello,
>
> I'm a bit confused on inheritance. In the following example of a
> proxy, do I need to be aware of a parent's hook and handle it
> specially?
>
> class Loud
> {
>     public string $name {
>         get {
>             return strtoupper($this->name);
>         }
>     }
> }
>
> class LoudProxy extends Loud
> {
>    public string $name {
>        get {
>            // detected the parent has a hook? //
>            $return = parent::$name::get();
>            // do something with return //
>            return $return;
>        }
>    }
> }
>
> what happens if the Loud class later removes its hook implementation
> (ex: moves it to the set hook)? Will my proxy now cause an error?
>
> Would simply calling $this->name call the parents hook?

Per the RFC:

"If there is no hook on the parent property, its default get/set behavior will be used. "

so parent::$name::get() will "read the parent property", which will go through a hook if one is defined, and just read the raw value if not.  So there is no detection logic needed, and the parent can add/remove a hook without affecting the child.

Calling $this->name in LoudProxy's get hook will access backing property on LoudProxy itself, ignoring the parent entirely.

--Larry Garfield