Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122684
Message-ID:
 <AM8P250MB0170AF0B845A20BD03131E03E22C2@AM8P250MB0170.EURP250.PROD.OUTLOOK.COM>
Date: Tue, 19 Mar 2024 01:05:08 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] Re: [RFC] [Discussion] [VOTE] Rounding Integers as int
Content-Language: en-US
To: Marc Bennewitz <marc@mabe.berlin>, internals@lists.php.net
References: <1295818d-5b01-4c94-ac21-d6645d784de4@mabe.berlin>
 <AM8P250MB017015AA541949DF83D31496E22E2@AM8P250MB0170.EURP250.PROD.OUTLOOK.COM>
 <4ffaf3a6-aa95-4c01-a4ce-edebbd4ec11a@mabe.berlin>
In-Reply-To: <4ffaf3a6-aa95-4c01-a4ce-edebbd4ec11a@mabe.berlin>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: AM8P250MB0170:EE_|AS4P250MB0462:EE_
X-MS-Office365-Filtering-Correlation-Id: 29225c2b-fbf8-430c-85c1-08dc47a83dd0
X-MS-Exchange-SLBlob-MailProps:
	YfhX3sd/0TVtq4avcNPNE0XRC8HkTjezpnNHt+HC0SapwlBxyHd/YMMDZwKs7qT45q/TQlYxXfGplJT3ZWck7oL8yMn29Rwc9UiKzT14VMXEx+76sJRsr+FRvkL2FxDD6YC4HIKu/rOr362yKyTDW5anYGMGA/VqvUA+6HIjrm/dGAfJchgAIkLyT1NtKmmWyEeWpN/9ATQtJAwQbyRzwI4lOPCTwIppwMY42KZC/+fnc3gKKFLJE1TW83z+vMmj/Nkqe++4qAoyoiq2fIcdvqLpPjf1DQM3qXCAQ3nopS4/nW/rV3KhAWTPMQStbsfCHB+DxoqHNvhWiYaVixjEYBXGwlwfoHYDTBpoo/TajGtvPQdHQPgwdnUoIZ1yaeWiPqy780gULo2GXHangoZRZZpYmcJ3fw6h9smFJTd05zJ0DW8L1ynM/a3LLkOXSAtg88y/1GPfis8Jwnsn3zsThTWlkDf1729Mr5x01wJxlxVsTw5uKORq8icDEGaGw+22uKeqQf0tPUAKW/emlCgZNwJWXwr7WSkRPzWXaje/XCOjx3yz4TxAS4w+RQQlJyTf5DWnrqmZus7Y3vcpwj1FwnJDLG9l86xKp/KosTf4W3z0a6vEdsFXry1D6UMKgtqv/68SRb4OIOxon2ntRsYNrL8B+hkYyPmuQy6zp0BkfZLf9QhdPYE9PqTOg6uT1LMdfhklUBfmziOLIvLXJHAPwLHsv7JR10CvIRYFtuayARFoQtNbVkY/KOl+An2bKX91UzUcuOhU1TksH7Gvx7m/l8uudE/MzxJhk47A45DoYHQ=
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AjpCIC7RvfkCDfO40FvVvc7CT00Dp92xMHgMDIvtPqQdBU2/n2CN99WfJ9xARorrCpUxDtlRlQeN6EZKMZ/OtBXA9kXO0mIkeDko9GPCfNh6i8DkkZL5G6WEnBOVZpfqSkPzqAKWzqNadKhOQ2oIC+1N79Kph2xwVOH22tafkKD5C5P3IjbkjPHBzK9vmR0c8OnfHnafd0f5Nb7jVC+E1j9m6iEMMsUCWcN3pMlY5ik0eifwZr2n0tK+jl2XNzStXB80LTH/rh0UFCaUs2emJWWBTgO2/hndimvU3fg8eeUtQeOD0690tGiHC3I6PqeyJPsQlAdjYy+j2XB8o2PkZ0tZCMpBTwhQtDvbd3znBJ4nvL1zWBg51fdkwxrWAjrjYtcAksxb/m6O5Bbi6+ES6WXJ6vMFS9cok2i19TzIQ0OhUtpktPCgmjXGkqCDTg58GJa2gxws9T3o0nfF0wTT1uuVwDMLvKXe+Bq1wvTtjhrasmPborCL+s37I4yChKkX/WIKgL2djAh9Cy8yDhkN2rJqvRhsRrDcjRmDP1gtmF9z0WRyUWJ54Ef5jH1mh2KwNXOst+QZx0ze0vQvBt+3RApeIG+PlyqagWar8V+EL5s8JbhnewgLftkc69EURcRoKo1hlnlBbTo2CeTY8c6auy8OAat6UfQunkeWiXCmd6M=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cHhwNkpSUVBDUXhqNVB0NUFFNStWOFVNU05FT2lMZFBsaE9jaGpQL3ZOSjUz?=
 =?utf-8?B?V3ZJYmZxenovYi9kck9oaWtyNjMvZkJGdmNHYW5kQXNoM29FU05FVVBCckx3?=
 =?utf-8?B?eStjK2lsanNobGhhdU80MlZ0ZTliblFZOUhMTlRXelIydWFiNS9JYXorRjcx?=
 =?utf-8?B?QzJBSFI2YjJDell1Nkg2VDE1SDVzc0FCT1ZkN2NuK3NwWXBCQmJ4d05XWkpW?=
 =?utf-8?B?OURxQXRUZGIzV3BHcldIVnZlRmJyQzhEYWwwOXJiS0JLTDhzS3BKYzhzOUJQ?=
 =?utf-8?B?RmNRSmtiRm9vRExpRUlnMElsZXJGNGVWZ0xicWdIcS9mUGp0ZjhyaTg3a0pY?=
 =?utf-8?B?SWU2YXdwUGd2T2o5VmxmZ2NJcE1Ob2I5RWNrZGJNWnkxN0lBZGc0dXBCb2tI?=
 =?utf-8?B?L1ptK1YzRkkwYUNOa3ZlaTNtdmJFV2lhWStZZlVDT084NERwelorYmhYQnJZ?=
 =?utf-8?B?MU56VzRKOFBNTHFrS3ZoczZISWxoZ2pkaWNPSWtSZTAxSkFaMWlPRUh4STZQ?=
 =?utf-8?B?KzJnU1ZPS3duZHlpRVA3YnZ3RW9TRFRsWkFsYVROK0tRUE1CWUpEMG5uNnVB?=
 =?utf-8?B?bHdyQVc2YU5vbmtSOGJYTGRPS0JiQ2NwMkpLZ2g4ZjBJazMzVkZFM2ZDMXhs?=
 =?utf-8?B?a3BUSFRqYjZLTzBkNzlwSUY4WVQzdDJoODh4T3dDdHhZcm01WitlYUVBeUdn?=
 =?utf-8?B?b2ZKN2pKTmVyYjFCOU1QNzhJblpiM0ZYaUh4dW5jVEdsRkVna2xpZW0rYlVZ?=
 =?utf-8?B?cnN4ZXF4Y2RtRkVJaXZEZDNBZ01xRkJDNGQrbFE2OE5MSnY4emdOWGU2NHIx?=
 =?utf-8?B?RGc2TDlDZ0pVUW5lMjZSY3dLUzhjSDVSL2RXekI3QWZkOUlvTW1LWUdOZkVa?=
 =?utf-8?B?ajJXQjcraWtSdVVzQzV2Sm5OSFRYSjJSdDZ2SFZldDRFclB2NWpjeGNiTlY2?=
 =?utf-8?B?eUpwVGc5Ym9tQmNIdnRzK0pXdGtCRE96bnBBcDY4bENBckt0ZGJ4ZjJtWmVL?=
 =?utf-8?B?eDJ3Wjk5Z3FQZEcvQTNRcVBRbXlLdmFLTks4RE9CaG9LZW52dlVNQnhOamtz?=
 =?utf-8?B?UHpRQlhhL3hmNzlXdDBnVWQrZk5tZUR3NmxEUVBWU3dyRUxoZkxVc1A4ZTEz?=
 =?utf-8?B?N0M5L3F5M29pT1VuUWErUHVuMlZTZXRReUVZbWcrc1pHN3FtVUhJU2VCVlVT?=
 =?utf-8?B?eHcrYnF5eVp1S0RScHk1MDJnelY5blFQV3FzK1dTOFdHaVBpc0NYS2QvSFo0?=
 =?utf-8?B?NURuTElLcWJPTGxLUlZMcFpiMEp3WmxQQUNzWTNVRXEvTW1HaituQmgraE8v?=
 =?utf-8?B?cUVFaHE3a0psMDZFK0piVkFpL0l0eDdQVlRKdGt6Ymt4TWh0dDBvZDY5YytF?=
 =?utf-8?B?amsvNStFVjFIek9IYTBLNFpqeExHUzJ0QUd4UzFFYWN1WnJ5UE9sdklBNkgz?=
 =?utf-8?B?UmtWNVRqaVhsRUE4S1dhMlN5c2pUVmJISE8rOXRaUXhpMjQzclZqY29qaGE5?=
 =?utf-8?B?ZERqN1FGazdLNW8yN0szNDNPNDBRaG04d0o1L0plRHhKdForNmNwYUF3NUlq?=
 =?utf-8?B?RVl1L01Dc0N2UjNVU3E2VTdGTjJVdmhnVmo4Z1g0dXlZRitVVjJScDUySU5q?=
 =?utf-8?B?K0N2V3lSbENXV1lFWk5iYWgxekFVcXNrNmhBUDJQcTJyMElEMFVLZ2NDZTZi?=
 =?utf-8?B?cFF2bW9ITW5MZUpUUzVacXlZRmxRMGNVTEVxdDJtSlBCQmVzLzZ3b3c4SWsw?=
 =?utf-8?Q?RhfIeWmTpll0ltmdUw=3D?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-e3d53.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 29225c2b-fbf8-430c-85c1-08dc47a83dd0
X-MS-Exchange-CrossTenant-AuthSource: AM8P250MB0170.EURP250.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2024 00:05:10.0761
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4P250MB0462
From: bobwei9@hotmail.com (Bob Weinand)

Hey Marc,

On 18.3.2024 08:53:01, Marc Bennewitz wrote:
> Hi Bob,
>
> On 17.03.24 14:59, Bob Weinand wrote:
>> On 17.3.2024 13:23:04, Marc Bennewitz wrote:
>>> Hello internals,
>>>
>>> I have opened the vote for the "Rounding Integers as int" RFC:
>>> https://wiki.php.net/rfc/integer-rounding
>>>
>>> Do to Easter weekend the vote will run for two weeks and two days 
>>> until Tue the 2nd of April 2024.
>>>
>>> Best regards,
>>>
>>> Marc Bennewitz
>>
>> Hey Marc,
>>
>> I've voted no; it should be just changed without any force_float 
>> parameter. Just always return int when possible (and the input was int).
>> If users wish to have the old behaviour, they should just explicitly 
>> cast via (float).
>>
>> The effective BC break of that would be quite small if some things 
>> which return float today now would return int. I cannot imagine many 
>> cases where this would actually be unwanted. And as said, explicit 
>> (float) casts are always possible.
>>
>> I also dislike force_float, as it cannot just be added to a function 
>> in any code which shall be backwards compatible to 8.3 and older. It 
>> would just emit Uncaught Error: Unknown named parameter $force_float.
>
> Changing the return type from float to int is a non trivial quite hard 
> to find behavior change.
>
> Imaging code like this:
>
> $x = 800;
> $y = 800;
> round($x/$y) === 1.0;
>
> This will return false instead of true especially because we teach 
> users to use strict comparison.
> Such behavior change should be done in a major version.

I see, here we disagree:
- Strict comparison should be avoided when working with numbers. Strict 
comparisons are generally for strings and booleans.
- There's no reason to artificially wait years here.

> With the additional parameter it's possible to opt-in into the new 
> behavior already in 8.4 while in PHP 9.0 the default behavior will 
> change but previously opted in code does not need to get touched again.
>
> Just changing the behavior means waiting for PHP 9.0 without a way to 
> opt-in in 8.4 already. If you are not interested in opting in in 8.4 
> already you can just ignore the additional argument as this will be 
> the default in 9.0.
I'm not interested in having an additional parameter I have to carry 
forward for quite some years.
> To mimic the previous behavior in a fully BC way it's as simple as 
> explicitly casting the value to float.

I would rather have preferred to see a static analysis solution how 
often round()ed results are compared strictly, assess the actual BC 
impact and possibly encourage tools like Rector to recognize such patterns.

>>
>> Bob
>>
> Regards,
> Marc

Bob