Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122669
Precedence: bulk
MIME-Version: 1.0
References: <1295818d-5b01-4c94-ac21-d6645d784de4@mabe.berlin> <AM8P250MB017015AA541949DF83D31496E22E2@AM8P250MB0170.EURP250.PROD.OUTLOOK.COM>
In-Reply-To: <AM8P250MB017015AA541949DF83D31496E22E2@AM8P250MB0170.EURP250.PROD.OUTLOOK.COM>
Date: Sun, 17 Mar 2024 22:59:11 +0100
Message-ID: <CABEW5qf2WTWmyhQG+rQnOD5AUSKhSUiPkJTbB30F85KoqyoTOw@mail.gmail.com>
Subject: Re: [PHP-DEV] Re: [RFC] [Discussion] [VOTE] Rounding Integers as int
To: Bob Weinand <bobwei9@hotmail.com>
Cc: Marc Bennewitz <marc@mabe.berlin>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000008533cb0613e25a54"
From: misterdeviling@gmail.com (Vincent Langlet)

--0000000000008533cb0613e25a54
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

IMHO, the more meaningful cases of the RFC are missing :

round(float, precision: >=3D 0): int|float // only cast to float for int ov=
erflow
ceil(float): int|float // only cast to float for int overflow
floor(float): int|float // only cast to float for int overflow

Calling ceil or floor on integer is meaningless, because it will return the
same value.
The RFC should be "Prefer int as return value when possible".

Le dim. 17 mars 2024 =C3=A0 15:00, Bob Weinand <bobwei9@hotmail.com> a =C3=
=A9crit :

> On 17.3.2024 13:23:04, Marc Bennewitz wrote:
> > Hello internals,
> >
> > I have opened the vote for the "Rounding Integers as int" RFC:
> > https://wiki.php.net/rfc/integer-rounding
> >
> > Do to Easter weekend the vote will run for two weeks and two days
> > until Tue the 2nd of April 2024.
> >
> > Best regards,
> >
> > Marc Bennewitz
>
> Hey Marc,
>
> I've voted no; it should be just changed without any force_float
> parameter. Just always return int when possible (and the input was int).
> If users wish to have the old behaviour, they should just explicitly
> cast via (float).
>
> The effective BC break of that would be quite small if some things which
> return float today now would return int. I cannot imagine many cases
> where this would actually be unwanted. And as said, explicit (float)
> casts are always possible.
>
> I also dislike force_float, as it cannot just be added to a function in
> any code which shall be backwards compatible to 8.3 and older. It would
> just emit Uncaught Error: Unknown named parameter $force_float.
>
> Bob
>

--0000000000008533cb0613e25a54
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,=C2=A0<br><br>IMHO, the more meaningful cases of the RF=
C are missing :<br><pre style=3D"font-family:&quot;Source Code Pro&quot;,&q=
uot;Courier New&quot;,Courier,monospace,sans-serif;background-image:initial=
;background-position:initial;background-size:initial;background-repeat:init=
ial;background-origin:initial;background-clip:initial;border-radius:0px 0px=
 2px 2px;color:rgb(51,51,51);margin-top:0px;margin-bottom:1.5rem;padding:0.=
75rem;overflow:auto;max-height:50em;max-width:99%;font-size:16px">round(flo=
at, precision: &gt;=3D 0): int|float // only cast to float for int overflow
ceil(float): int|float // only cast to float for int overflow
floor(float): int|float // only cast to float for int overflow</pre>Calling=
 ceil or floor on integer is meaningless, because it will return the same v=
alue.<br>The RFC should be &quot;Prefer int as return value when possible&q=
uot;.<br><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_att=
r">Le=C2=A0dim. 17 mars 2024 =C3=A0=C2=A015:00, Bob Weinand &lt;<a href=3D"=
mailto:bobwei9@hotmail.com" target=3D"_blank">bobwei9@hotmail.com</a>&gt; a=
 =C3=A9crit=C2=A0:<br></div><blockquote class=3D"gmail_quote" style=3D"marg=
in:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1e=
x">On 17.3.2024 13:23:04, Marc Bennewitz wrote:<br>
&gt; Hello internals,<br>
&gt;<br>
&gt; I have opened the vote for the &quot;Rounding Integers as int&quot; RF=
C:<br>
&gt; <a href=3D"https://wiki.php.net/rfc/integer-rounding" rel=3D"noreferre=
r" target=3D"_blank">https://wiki.php.net/rfc/integer-rounding</a><br>
&gt;<br>
&gt; Do to Easter weekend the vote will run for two weeks and two days <br>
&gt; until Tue the 2nd of April 2024.<br>
&gt;<br>
&gt; Best regards,<br>
&gt;<br>
&gt; Marc Bennewitz<br>
<br>
Hey Marc,<br>
<br>
I&#39;ve voted no; it should be just changed without any force_float <br>
parameter. Just always return int when possible (and the input was int).<br=
>
If users wish to have the old behaviour, they should just explicitly <br>
cast via (float).<br>
<br>
The effective BC break of that would be quite small if some things which <b=
r>
return float today now would return int. I cannot imagine many cases <br>
where this would actually be unwanted. And as said, explicit (float) <br>
casts are always possible.<br>
<br>
I also dislike force_float, as it cannot just be added to a function in <br=
>
any code which shall be backwards compatible to 8.3 and older. It would <br=
>
just emit Uncaught Error: Unknown named parameter $force_float.<br>
<br>
Bob<br>
</blockquote></div></div>

--0000000000008533cb0613e25a54--