Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122666
Message-ID:
 <AM8P250MB017015AA541949DF83D31496E22E2@AM8P250MB0170.EURP250.PROD.OUTLOOK.COM>
Date: Sun, 17 Mar 2024 14:59:05 +0100
User-Agent: Mozilla Thunderbird
Subject: [PHP-DEV] Re: [RFC] [Discussion] [VOTE] Rounding Integers as int
Content-Language: en-US
To: Marc Bennewitz <marc@mabe.berlin>, PHP internals <internals@lists.php.net>
References: <1295818d-5b01-4c94-ac21-d6645d784de4@mabe.berlin>
In-Reply-To: <1295818d-5b01-4c94-ac21-d6645d784de4@mabe.berlin>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: AM8P250MB0170:EE_|AS8P250MB0088:EE_
X-MS-Office365-Filtering-Correlation-Id: 4ab1d855-f802-4b83-ee2c-08dc468a69c1
X-MS-Exchange-SLBlob-MailProps:
	obhAqMD0nT9pc207ciP66+/HCCDrHbas2tSJk7Hm+ufN2mUZu8+Si8N/fv79YuB9Pbo98cehsoJWQ3uBEYQGOrROC9Cj3fUJzZapUMNH/mCocuOTBYciWDnAGLBzqUe63c1AxemmxIH07kEpMra7eBJhbdTqHqsB+29SVXTxpUVLZR0AC7iRS8pbfxb5Dvm4ezE4cOfldXNc5OJRPVXL0XzZ4QKyB6usP3/VSm4M1Ub3Te/fHy3JxOFw9ecgvezm8vc6g80QRN11GdjJwkTsbQgy1X4deF6qXcMLAH2cRHF6qMNZgHMbMAhQfhVg5zFQ0ddfF+JIO9g1Da2VQlopAsjwNMZfqE0SwPiEc03PRwuA2Eeeo4cEpQfxozEDdNVYTIchRnp03s0lB/RUjCn372QKp9zMMRf93b+AomLTVjMFsJFbtYlhM5HMRoeqIGZChA62ciEWLiUNQ5CjGem9bePZIeMFHWbcAI9PCfui3w/OARMAmClbAa51VJDvkQ1J3xvOP78pqs0fSvpe6V0WVrQmbkGr8mMpBrUpwMiBq9koNRVk/FZNP0obevRjRASi2RtuiOnkv5LNBWyEsYOcPNLlzWc5oNUFutHRrqb9e1b6YlptsA64+IKWzXAhIngNePnfDc0elT/ZhGQQ+Mc80uwhAurjVcCGxnEfXNQa2OmEzv1ZIw8d+N7cpYMebWxXqFMC787QDO3rXTTW6e7HHn0iuhc34Awgs0j5lqtmCD6Af3X6PaGrxxm3S/xuuRa9R3sgF3D5Xzoy+zi2g6fBANpSi7FJ52raiEv72fxrpljZD3CzoqxMaZ9WYOnTS0Ro
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6yaIm18tTMW6BroWcy/igzFAW8PgvYTSWyZ6Izfefz+2VsMsNeZAY/NogqaDBBkTUHJgiT+O1WRvHANMTLIJFatjmuXqolQh4Y+K/ZbiwSSyNVhQPBjCz8yhLgJe6IAApMgLl+2VLTz4zh7Dm/TXqAcHOufjf1efZEaF50rOaMMrCwvqCSj1gUZ1IwsT+fIBkLzGch0BT5uUpPZpqhK0rzLrRNcv7hqyDghrZVGmBvgqqlRoSMkK755XbC3AKCVQf5xqlWKtXS+AO6GCK3XlC6ENa7+2R4IhVPrPrIw+01sM8WXTh+FVqIr09CY8rNkTKOwwebbOjx08Cg0KP0Hvj2Ji01rrojDxSkZHi/7p42gcexvm0isHzCY1Zn+c+FQMmK9SBni1lq4EceJEqGr8UaiI14dkzyXRHGqm52Q1GZuaR3DZl6Z2Lp/eOpTAZdaSJO9Q7MvL0Jp2W4KjsB0Xnil0Sjq5pqwhyVHDl6RilJiqkmM6FLwSExxTwoTCaEEMfCjXdvo7LWYiX4Tk3S8lz5nQBt+W7yVUnnsccTxI7eqvXz4ToT0ao9k73OOodDHwFWfa5jUKbHwB/4/B4NPnA0yTLAxVzsvtqeKuFv0ezQSiDK4xg+XnxEWBjbrF2pxIS/Edsz5V/272y76++CsPxKvBdW8xUMw3WnaMzadRgWI=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZVJtV2QvMTZFZ1gvOUk0RFRFUGVXbExHbDcvb25ONGQzVEh5OWlxRmZ1WVJJ?=
 =?utf-8?B?eWVWL3ZLL3hkTGUrNkU1ZERPbDZFK1dkbFkxSlVCK1Nxa0ZhTkp3Q2Y1MTho?=
 =?utf-8?B?U0JJTE9ZK1FWRzZ4RFBDY3dYcjVWbUc3Rnhka2dyYlVNdlN2UXl1VEFnZmxT?=
 =?utf-8?B?M3crNXFsNHI3bi82WVdldTZVZzF2OHlTNjgvaVBjZDNvcU5yVEovcjVyZVlm?=
 =?utf-8?B?MzdWR3VMeFk3ZWtXbGVKaDlTdU03eEpBZDFSLzROU0ZzV0xsZW9sM1ZUU2lV?=
 =?utf-8?B?VSswZGJ2a1dMc0JtWElSdzc3dUdYNWVvYlV6NVdtMWQyWmJKUGtCTXVrZXBa?=
 =?utf-8?B?SlFIZ0R4YlhCZmlkUk03eENUZm9FVjMzaVFMdkJaWHRnV3d3ck44a2E3Ym9m?=
 =?utf-8?B?ZDg5U1l5eG9IQkxMckVFVGpiempWYlltRnR4QzlxRjdHeER6cnlTeURjclNO?=
 =?utf-8?B?S1N5T1VZY3QzTm84QnpoK2x0bmxsM2YvZEJwTHlsZ25GYjQwb0pjWFZoUGVy?=
 =?utf-8?B?dFRpaUtlNDZBSlJubW4xdTZKZklFNVVOazZZOGw1bS8rcmVHQ01SdVE0NjFE?=
 =?utf-8?B?a2pra3RQS1JhQWMrNnBsdjg0TFhydVdwcWRnV1RwTHJDRnpTalErdHNqMDdE?=
 =?utf-8?B?aUR2VTd6TStueDVOQlcxdDZQWDc4c0hwbkViWG5SUHc4MTQ3R3JyVEhEaHR1?=
 =?utf-8?B?YVJZZjNsK2c2Nmxmb3VDUSt3RG5YQWVwZmVKRWhrelhoeEhUSGtEMTlxdGNE?=
 =?utf-8?B?TlBkblYrQVlPWkR2bzNmYlhWc2RwN2l2aG1zL2NqcWVFVi9lWXJTdGFQNjcx?=
 =?utf-8?B?OFBiUXl1dFJwcXo1dEgyYllBUHNSZmhjTlJIU0Fycy9UUElTRGVnaGZxWmg0?=
 =?utf-8?B?TWhnVUpWSXI1UXQxUlBNZzkydnJsTzFJbWZrald0WnY5Y2VyTWdPTmM3SWlT?=
 =?utf-8?B?Z0ZiUHc1ZDBQL242NnJETy9yb2lVZzBOdk1zaUpCbnk2cWg4UjYwUmlvNUZB?=
 =?utf-8?B?WmpNMlZkTHV1a0tYNkR2c1JBamQ5STh4YTU0cHNnSjJwTzhMWkNuZzVydjJk?=
 =?utf-8?B?czBvdStuMW9NN3Q3ajFEVHdldTJ6SjArMC9KbWlnWTgwbGM4eHhaRHFXQkor?=
 =?utf-8?B?aWdDMDJCR1ZxbDkwcHRKdjh3Rmw2cm1MQ2d5eUhERW03ODZvclUwM3NqOGwz?=
 =?utf-8?B?ZjREbjh5c09jbncvQnl2Sk8zTGRPRFNVQUdGdWxqWjUvUWxWQmpHMnB2Z2V5?=
 =?utf-8?B?aUE5YWxPNDVkRnhja2VmZGcwRDZtTXZXSUlVZnFrV0VoQ0Q2QkpXSVlKZlI3?=
 =?utf-8?B?NXR4b1lRUkRLRmxOTmlNNGs4czRDT2Z4V0VuQzc1OEdYeDZSbVdoMUN3dnNx?=
 =?utf-8?B?ZDhuNzR5YzZ4eDdYWmpNSlM2QUt0b2M0eWFtMzczeS9mallRTFc1cXRUTEpp?=
 =?utf-8?B?S1E4Qy9sdDNobE1BellFUGVhbE9JL3VHNmV3Rk1EdkRHRlFDMTVLblh3amdK?=
 =?utf-8?B?N0RSRXpqUHRLSkVteG1DZ25wbDRYQVgwYi9MYmlTc0RFNkQyYjJIOWlmeUty?=
 =?utf-8?B?SkpsWmE5MjdJRVpiUzJzOE9xd09vMFRsZ3BUb0NRakZYRi9aTTM1a1lNYmRk?=
 =?utf-8?B?cEJ1TUF2ODB2SmVCL3hIQzV0ZUxNNUJuT011ekdzb2pYWWJua0RSYXZFbUc5?=
 =?utf-8?B?VHBGcTJXZlRTOHFIRzN6NkFEVzd4clpNbUlpNGFYc3lzNWhSblN2dmx6Q0xO?=
 =?utf-8?Q?s5RjIUAngd4qsr51/g=3D?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-e3d53.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ab1d855-f802-4b83-ee2c-08dc468a69c1
X-MS-Exchange-CrossTenant-AuthSource: AM8P250MB0170.EURP250.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2024 13:59:07.7109
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0088
From: bobwei9@hotmail.com (Bob Weinand)

On 17.3.2024 13:23:04, Marc Bennewitz wrote:
> Hello internals,
>
> I have opened the vote for the "Rounding Integers as int" RFC:
> https://wiki.php.net/rfc/integer-rounding
>
> Do to Easter weekend the vote will run for two weeks and two days 
> until Tue the 2nd of April 2024.
>
> Best regards,
>
> Marc Bennewitz

Hey Marc,

I've voted no; it should be just changed without any force_float 
parameter. Just always return int when possible (and the input was int).
If users wish to have the old behaviour, they should just explicitly 
cast via (float).

The effective BC break of that would be quite small if some things which 
return float today now would return int. I cannot imagine many cases 
where this would actually be unwanted. And as said, explicit (float) 
casts are always possible.

I also dislike force_float, as it cannot just be added to a function in 
any code which shall be backwards compatible to 8.3 and older. It would 
just emit Uncaught Error: Unknown named parameter $force_float.

Bob