Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122630
Message-ID: <9114cbe3-2b9c-4037-856b-20afc8f96f95@FamilleCollet.com>
Date: Wed, 13 Mar 2024 17:06:01 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: [PHP-DEV] base64_encode without padding
To: php internals <internals@lists.php.net>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
From: Fedora@FamilleCollet.com (Remi Collet)

I think padding should be optional (on by default to keep BC)

Of course in user land, simple to write

   $enc = trim(base64_encode('foo'), '=');

This proposal allow to simply use

   $enc = base64_encode('foo', PHP_BASE64_NO_PADDING);

And also expose it for extension as

   PHPAPI extern zend_string *php_base64_encode_ex
     (const unsigned char *, size_t, zend_long flags);


Use case: for ARGON2 password hashing
see https://github.com/php/php-src/pull/13635

It may seems ugly to add and remove th padding char

Is a RFC needed for such a minor feature ?


Remi