Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122624
Precedence: bulk
MIME-Version: 1.0
References: <fca97d6c-d4ec-4000-958a-72c32beb8421@app.fastmail.com>
 <a715dacb-9bac-4bea-a2bb-c623737fd81e@app.fastmail.com> <87171309-BD28-4292-A502-93DC720F445C@koalephant.com>
 <ec17bb5c-bc5a-40d3-81eb-27fc43577b58@app.fastmail.com>
In-Reply-To: <ec17bb5c-bc5a-40d3-81eb-27fc43577b58@app.fastmail.com>
Date: Tue, 12 Mar 2024 18:53:45 +0200
Message-ID: <CAAwdEzD-FjfwUVDoFyEBp+4RpQ8u5D6yzh4JsykM12TXqnRM0A@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC[ Property accessor hooks, take 2
To: Larry Garfield <larry@garfieldtech.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000006769b8061379812c"
From: drealecs@gmail.com (=?UTF-8?Q?Alexandru_P=C4=83tr=C4=83nescu?=)

--0000000000006769b8061379812c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 12, 2024 at 4:36=E2=80=AFPM Larry Garfield <larry@garfieldtech.=
com>
wrote:

> On Tue, Mar 12, 2024, at 8:49 AM, Stephen Reay wrote:
>
> > Hi Larry
> >
> > Thanks again for both of your work on this, I'm really hopeful this
> passes.
> >
> > Was there ever any further discussion/resolution/decision about the use
> > an explicit `virtual` keyword, and the related flag for creation of a
> > backing store? I thought it was discussed by several people but I don't
> > recall seeing any eventual consensus, and it looks to my eye that it
> > hasn't changed from the original proposal: i.e. it's 'magic' and
> > `$this->{__PROPERTY__}` won't work?
> >
> > Is that correct?
>
> We looked into `virtual`, and considered it, but determined that it
> wouldn't actually work because of inheritance.  Details are in a new FAQ
> entry:
>
> https://wiki.php.net/rfc/property-hooks#why_no_explicit_virtual_flag
>
>
>
Nice that you added the details there why explicit virtual is not a good
idea.

So, if the parent class changes between virtual and non-virtual, while the
child class is virtual, the only tiny BC break will be in the reflection as
we will see a change between virtual and non-virtual?

Alex

--0000000000006769b8061379812c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Tue, Mar 12, 2024 at 4:36=E2=80=AF=
PM Larry Garfield &lt;<a href=3D"mailto:larry@garfieldtech.com">larry@garfi=
eldtech.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex">On Tue, Mar 12, 2024, at 8:49 AM, Stephen Reay wrote:<br>
<br>
&gt; Hi Larry<br>
&gt;<br>
&gt; Thanks again for both of your work on this, I&#39;m really hopeful thi=
s passes. <br>
&gt;<br>
&gt; Was there ever any further discussion/resolution/decision about the us=
e <br>
&gt; an explicit `virtual` keyword, and the related flag for creation of a =
<br>
&gt; backing store? I thought it was discussed by several people but I don&=
#39;t <br>
&gt; recall seeing any eventual consensus, and it looks to my eye that it <=
br>
&gt; hasn&#39;t changed from the original proposal: i.e. it&#39;s &#39;magi=
c&#39; and <br>
&gt; `$this-&gt;{__PROPERTY__}` won&#39;t work? <br>
&gt;<br>
&gt; Is that correct?<br>
<br>
We looked into `virtual`, and considered it, but determined that it wouldn&=
#39;t actually work because of inheritance.=C2=A0 Details are in a new FAQ =
entry:<br>
<br>
<a href=3D"https://wiki.php.net/rfc/property-hooks#why_no_explicit_virtual_=
flag" rel=3D"noreferrer" target=3D"_blank">https://wiki.php.net/rfc/propert=
y-hooks#why_no_explicit_virtual_flag</a><br>
<br>
<br></blockquote><div><br></div><div>Nice that you added the details there =
why explicit virtual is not a good idea.</div><div><br></div><div>So, if th=
e parent class=C2=A0changes between virtual and non-virtual, while the chil=
d class is virtual, the only tiny BC break will be in the reflection as we =
will see a change between virtual and non-virtual?</div><div><br></div><div=
>Alex=C2=A0</div></div></div>

--0000000000006769b8061379812c--