Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122608
Precedence: bulk
MIME-Version: 1.0
References: <fca97d6c-d4ec-4000-958a-72c32beb8421@app.fastmail.com> <a715dacb-9bac-4bea-a2bb-c623737fd81e@app.fastmail.com>
In-Reply-To: <a715dacb-9bac-4bea-a2bb-c623737fd81e@app.fastmail.com>
Date: Mon, 11 Mar 2024 09:35:09 +0100
Message-ID: <CABdc3WrxQx4GOgXdo9UeryXY+aFHB_+0hAjwT6z-=dS8jMet9g@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC[ Property accessor hooks, take 2
To: Larry Garfield <larry@garfieldtech.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000061fed06135e6cd9"
From: michal.brzuchalski@gmail.com (=?UTF-8?Q?Micha=C5=82_Marcin_Brzuchalski?=)

--000000000000061fed06135e6cd9
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Larry,

pt., 8 mar 2024 o 16:55 Larry Garfield <larry@garfieldtech.com> napisa=C5=
=82(a):

> Hi folks.  Based on earlier discussions, we've made a number of changes t=
o
> the RFC that should address some of the concerns people raised.  We also
> had some very fruitful discussions off-list with several developers from
> the Foundation, which led to what we feel are some solid improvements.
>
> https://wiki.php.net/rfc/property-hooks
>
>
This RFC looks awesome, thanks Larry and Ilija I love the functionality in
its current shape.

Thank you everyone for the feedback so far, and if you still have some,
> please say so.  (Even if it's just to say that you're happy with the RFC
> now so we feel more comfortable bringing it to a vote.)
>

The only thing I don't like and can still be worked on is the reflection
mechanism changes.
The proposed methods isVirtual and getRawValue, setRawValue pair introduces
a need to catch exceptions which could be eliminated by subtyping
ReflectionProperty.
Having these methods on a separate subtype allows returning a valid value.
I realize this isn't trivial because for the last 2 days, I was thinking
about giving it a name and TBH cannot figure out anything feasible.
If this is not possible to put in understandable words then at least
mention it in FAQ and why not.

Cheers,
Micha=C5=82 Marcin Brzuchalski

--000000000000061fed06135e6cd9
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi Larry,</div><br><div class=3D"gmail_qu=
ote"><div dir=3D"ltr" class=3D"gmail_attr">pt., 8 mar 2024 o 16:55=C2=A0Lar=
ry Garfield &lt;<a href=3D"mailto:larry@garfieldtech.com" target=3D"_blank"=
>larry@garfieldtech.com</a>&gt; napisa=C5=82(a):<br></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex">Hi folks.=C2=A0 Based on earlier discussio=
ns, we&#39;ve made a number of changes to the RFC that should address some =
of the concerns people raised.=C2=A0 We also had some very fruitful discuss=
ions off-list with several developers from the Foundation, which led to wha=
t we feel are some solid improvements.<br>
<br>
<a href=3D"https://wiki.php.net/rfc/property-hooks" rel=3D"noreferrer" targ=
et=3D"_blank">https://wiki.php.net/rfc/property-hooks</a><br>
<br></blockquote><div><br></div><div>This RFC looks awesome, thanks Larry a=
nd Ilija I love the functionality in its current shape.</div><div><br></div=
><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border=
-left:1px solid rgb(204,204,204);padding-left:1ex">
Thank you everyone for the feedback so far, and if you still have some, ple=
ase say so.=C2=A0 (Even if it&#39;s just to say that you&#39;re happy with =
the RFC now so we feel more comfortable bringing it to a vote.)<br></blockq=
uote><div><br></div><div>The only thing I don&#39;t like and can still be w=
orked on is the reflection mechanism changes.</div><div>The proposed method=
s isVirtual and getRawValue, setRawValue pair introduces a need to catch ex=
ceptions which could be eliminated by subtyping ReflectionProperty.</div><d=
iv>Having these methods on a separate subtype allows returning a valid valu=
e.</div><div>I realize this isn&#39;t trivial because for the last 2 days, =
I was thinking about giving it a name and TBH cannot figure out anything fe=
asible.</div><div>If this is not possible to put in understandable words th=
en at least mention it in FAQ and why not.</div><div><br></div><div>Cheers,=
</div><div>Micha=C5=82 Marcin Brzuchalski=C2=A0</div></div>
</div>

--000000000000061fed06135e6cd9--