Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122546
Date: Sat, 02 Mar 2024 11:48:00 +0000
To: Stephen Reay <php-lists@koalephant.com>
Cc: Larry Garfield <larry@garfieldtech.com>, php internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC[ Property accessor hooks, take 2
Message-ID: <O8ioUnzQ6TiBSdNGFNavEbEIVLN0-RHJt_nMx3k0yUoL1WMU-t9bifYMQF6ZPa9iV-8KSH_OFwg2L8yMHH7vvLKtAPyuldmB9hETlLBanzo=@gpb.moe>
In-Reply-To: <115C4A93-120E-45A4-85E2-D91649B66E70@koalephant.com>
References: <fca97d6c-d4ec-4000-958a-72c32beb8421@app.fastmail.com> <e0753ec0-0b73-42f6-95e6-e8e57d90ab5b@gmail.com> <59619244-917d-4936-8f21-2854840a9bf8@rwec.co.uk> <2299271f-50ea-48c1-81fb-b64fa10c9bbb@app.fastmail.com> <1204BFC3-B976-4FEE-BE01-E668699C84E2@koalephant.com> <f2ce7ebe-9faa-432b-9300-01c5e046478b@app.fastmail.com> <115C4A93-120E-45A4-85E2-D91649B66E70@koalephant.com>
Feedback-ID: 96993444:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: internals@gpb.moe ("Gina P. Banyard")

On Friday, 1 March 2024 at 06:28, Stephen Reay <php-lists@koalephant.com> w=
rote:

> For the third time: I'm well aware of how parameter types work everywhere=
 else, and that's why I'm asking why the same behaviour isn't being followe=
d here?
>=20
> - You've said you want to avoid boilerplate; and
> - You've said you would expect most people to just use the implicit `same=
-type $value` parameter; and
> - You've acknowledged that the existing 'standard' is that a parameter wi=
thout a type is considered `mixed`; and
> - You've acknowledged in your RFC that there is a use-case for wanting to=
 accept a wider type than what a property stores internally.
>=20
> So why then is it so unacceptable that the existing standard be followed,=
 such that a set hook with an "untyped" parameter would be treated as `mixe=
d` as it is everywhere else?
>=20
> Yes, I know you said "widening to `mixed` is unwise". I don't seem to rec=
all amongst all the type-related previous RFCs, any that suggested that chi=
ld parameters widening to `mixed` (either explicitly or implicitly) should =
be deprecated, so I'm sorry but I don't see much value in that argument.

Deprecating this behaviour would effectively mean, types are now required e=
verywhere, which is an unreasonable proposition.
The "implicit" widening to mixed is something that got introduced _after_ t=
yping was introduced to PHP, and quite "late" even (in 7.2) considering typ=
ing objects/arrays has existed since PHP 5. [1]

I don't think it's unreasonable that if property access hooks only work on =
typed properties, having no type means the type of the property and if you =
want to widen the type you _must_ specify a type.
Especially if you want the backing type to be mixed well you are just requi=
red to write a typed property with type mixed, same as readonly.

Best regards,

Gina P. Banyard

[1] https://wiki.php.net/rfc/parameter-no-type-variance