Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122514
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-153-g7e3bb84806-fm-20240215.007-g7e3bb848
Precedence: bulk
MIME-Version: 1.0
Message-ID: <b59c4e85-bede-4fe3-840b-b168d280fe17@app.fastmail.com>
In-Reply-To: <a8bdf9d6-d2ca-448e-8921-3a907e68f735@genkgo.nl>
References: <fca97d6c-d4ec-4000-958a-72c32beb8421@app.fastmail.com>
 <CAJp_myUayeQ=irpFUG0OrUj=PjE3_mx395h_ARSdLmdyEB6_EQ@mail.gmail.com>
 <790b5b4e-f51b-4050-a12a-5fa903d0568f@app.fastmail.com>
 <52C6F501-8E23-42D7-8541-88A22AD79375@koalephant.com>
 <36e90d8d-d275-4ce9-9dd9-1e2422c6d3a9@app.fastmail.com>
 <2fdf1933-b51c-40cc-8d02-31899b96c71c@genkgo.nl>
 <d4832238-7af4-4bd4-b8a1-8ab8d56d51d2@rwec.co.uk>
 <95e93cb9-3ab0-4cf3-8ec5-83e74c9dd607@genkgo.nl>
 <876aff9f-3eae-4d2d-8e3f-30dfbbeed49c@rwec.co.uk>
 <963f5cc5-cdb1-4384-b519-5cb15640654e@genkgo.nl>
 <58B82A81-8A89-4F17-B982-7FC36404032E@rwec.co.uk>
 <a8bdf9d6-d2ca-448e-8921-3a907e68f735@genkgo.nl>
Date: Tue, 27 Feb 2024 16:16:39 +0000
To: "php internals" <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC[ Property accessor hooks, take 2
Content-Type: text/plain
From: larry@garfieldtech.com ("Larry Garfield")

On Tue, Feb 27, 2024, at 10:01 AM, Frederik Bosch wrote:

> Hi Rowan,
>
> Our discussion sums up the pros and cons. Whether yield is 
> complicated/confusing or not, is maybe personal. The same applies to 
> getting $this->prop resulting in different calls. Larry has removed 
> $field from the RFC completely now, while I think it was a sensible 
> approach to read the current backing value. I think I have laid out 
> another alternative to writing with the yield/return suggestion. It's up 
> to the authors of the RFC to do something with it, or not. Thanks for 
> taking the suggestion seriously.
>
> Regards,
> Frederik

Ilija and I have discussed this, and we both agree that yield is not a viable option.  There is no generator or generator-like behavior involved in hooks at all, and a syntax that implies there is would be very misleading.  And adjusting the code to make it actually generator-based would make the code considerably more complex, and most likely slower.

It figures that people would start speaking up in favor of $field right *after* I removed it from the RFC text. :-P  At the moment, we're comfortable either direction.  (It hasn't been removed from the code yet.)  The main question is whether the trade-off of an implicit variable name and the potential for confusion is outweighed by the clarity about what is happening and where.  It sounds like most people are just really, really pissed off by an implicit variable, but that's based on the as-usual highly unscientific survey of "who replies to an email."  I will probably start a poll shortly to help get a better sense of what the actual voting population thinks.

--Larry Garfield