Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123202
Precedence: bulk
MIME-Version: 1.0
References: <CAEPJdumvJNQ+JZ3wkLP-Q2O0y57g=W_hHFkuvOKMVJqqraKCzw@mail.gmail.com>
 <CANS-=pdE8GX8-qpn3iZ_A7ZDKRW27mUhwA14rAtJmZOyZWa1-w@mail.gmail.com>
In-Reply-To: <CANS-=pdE8GX8-qpn3iZ_A7ZDKRW27mUhwA14rAtJmZOyZWa1-w@mail.gmail.com>
Date: Wed, 24 Apr 2024 16:55:32 +0200
Message-ID: <CAEPJdukkD_3PhP5mHogX4-LNNGFbRPiwU0zvgAvK9uaAHdy0yA@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3
To: Lynn <kjarli@gmail.com>
Cc: PHP Internals <internals@lists.php.net>, 
	"tim@tideways-gmbh.com" <tim@tideways-gmbh.com>
Content-Type: multipart/alternative; boundary="000000000000775df70616d8dd03"
From: kontakt@beberlei.de (=?UTF-8?Q?Benjamin_Au=C3=9Fenhofer?=)

--000000000000775df70616d8dd03
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 24, 2024 at 2:55=E2=80=AFPM Lynn <kjarli@gmail.com> wrote:

>
>
> On Tue, Apr 23, 2024 at 3:30=E2=80=AFPM Benjamin Au=C3=9Fenhofer <kontakt=
@beberlei.de>
> wrote:
>
>> Hi internals,
>>
>> My PR for #[\Deprecated] attribute was in hibernation for a long while
>> now and after some off-list discussion a few weeks ago I have decided to
>> revisit it and asked Tim to help me out with the work.
>>
>> Tim has cleaned up the PR quite a bit and also worked in additional
>> features such as #[Deprecated] support in stub generation.
>>
>> While there are still some small todos, at this point we want to restart
>> the discussion about the RFC for inclusion in 8.4:
>>
>> RFC: https://wiki.php.net/rfc/deprecated_attribute
>> PR: https://github.com/php/php-src/pull/11293
>> Old discussion: https://externals.io/message/112554#112554
>>
>> Let me know about your questions and feedback.
>>
>> greetings
>> Benjamin
>>
>
> JetBrains was mentioned in the previous discussion but not sure if this
> was considered in the RFC:
> https://github.com/JetBrains/phpstorm-attributes/blob/master/src/Deprecat=
ed.php
>
>

Yes we considered it, but this is one implementation of a vendor, it might
be conflicting with requirements of other projects and vendors. For the
implementation and the engine itself this information is just "weight" that
is carried around, so we decided not to add them, because its harder to
decide on what to include than recommending tools to add their own
supplemental attributes.

--000000000000775df70616d8dd03
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Wed, Apr 24, 2024 at 2:55=E2=80=AF=
PM Lynn &lt;<a href=3D"mailto:kjarli@gmail.com">kjarli@gmail.com</a>&gt; wr=
ote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px=
 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(=
204,204,204);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr"><br></div>=
<br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Tue=
, Apr 23, 2024 at 3:30=E2=80=AFPM Benjamin Au=C3=9Fenhofer &lt;<a href=3D"m=
ailto:kontakt@beberlei.de" target=3D"_blank">kontakt@beberlei.de</a>&gt; wr=
ote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px=
 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(=
204,204,204);padding-left:1ex"><div dir=3D"ltr">Hi internals,<div><br></div=
><div>My PR for #[\Deprecated] attribute was in hibernation for a long whil=
e now and after some off-list discussion a few weeks ago I have decided to =
revisit it and asked Tim to help me out with the work.</div><div><br></div>=
<div>Tim has cleaned up the PR quite a bit and also worked in additional fe=
atures such as #[Deprecated] support in stub generation.</div><div><br></di=
v><div>While there are still some small todos, at this point we want to res=
tart the discussion about the RFC for inclusion in 8.4:</div><div><br></div=
><div>RFC: <a href=3D"https://wiki.php.net/rfc/deprecated_attribute" target=
=3D"_blank">https://wiki.php.net/rfc/deprecated_attribute</a><br></div><div=
>PR: <a href=3D"https://github.com/php/php-src/pull/11293" target=3D"_blank=
">https://github.com/php/php-src/pull/11293</a><br></div><div>Old discussio=
n:=C2=A0<a href=3D"https://externals.io/message/112554#112554" target=3D"_b=
lank">https://externals.io/message/112554#112554</a></div><div><br></div><d=
iv>Let me know about your questions and feedback.</div><div><br></div><div>=
greetings</div><div>Benjamin</div></div></blockquote><div><br></div><div>Je=
tBrains was mentioned in the previous discussion but not sure if this was c=
onsidered in the RFC: <a href=3D"https://github.com/JetBrains/phpstorm-attr=
ibutes/blob/master/src/Deprecated.php" target=3D"_blank">https://github.com=
/JetBrains/phpstorm-attributes/blob/master/src/Deprecated.php</a>=C2=A0</di=
v></div></div></blockquote><div><br></div><div>Yes we considered it, but th=
is is one implementation of a vendor, it might be conflicting with requirem=
ents of other projects and vendors. For the implementation and the engine i=
tself this information is just &quot;weight&quot; that is carried around, s=
o we decided not to add them, because its harder to decide on what to inclu=
de than recommending tools to add their own supplemental attributes.</div><=
/div></div>

--000000000000775df70616d8dd03--