Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123191
Message-ID: <6dbe2789-d256-4420-9a41-59459291a4a1@wcflabs.de>
Date: Tue, 23 Apr 2024 21:23:38 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] RFC [Discussion]: array_find
Content-Language: de-DE
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>,
 Larry Garfield <larry@garfieldtech.com>
References: <24e4529d-0b75-44de-90ef-34de5dfb1c99@wcflabs.de>
 <278889be-82ab-4827-a9e7-801b5ba2d8f8@app.fastmail.com>
 <45b726f4-8085-43e2-b701-6b35bc249409@wcflabs.de>
 <d8a92e7a-539e-4753-bd27-5d59b17779ba@bastelstu.be>
 <2dd7ef64-d1c5-4ed8-964f-b86dba110e0d@app.fastmail.com>
 <cf6fed0d-ec60-4766-a594-34be1ee258d5@wcflabs.de>
 <4bdc94d9-f35b-423a-b3a7-1a91fbf48424@app.fastmail.com>
 <886bea6f-20a3-4f20-b773-7204a83a42dd@bastelstu.be>
Cc: PHP internals <internals@lists.php.net>
In-Reply-To: <886bea6f-20a3-4f20-b773-7204a83a42dd@bastelstu.be>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: josh@wcflabs.de ("=?UTF-8?Q?Joshua_R=C3=BCsweg?=")

Hi

On 19.04.24 23:17, Tim Düsterhus wrote:
> On 4/19/24 22:08, Larry Garfield wrote:
>> There's another issue, though: Will the callback always be given both 
>> $value and $key? 
> 
> The current implementation always passes both, which, as I just learned, 
> is inconsistent with `array_filter` which has the `$mode` parameter to 
> control what to pass to the callback.
> 
> Not that I claim that the `$mode` parameter is a good idea from the 
> typing perspective for static analysis tools, it probably isn't.

Yes, this method always passes both parameters. This has the advantage 
that we do not need a third parameter that specifies which parameters 
are to be passed to the function. The `array_filter` method was 
developed at a time when there were no closures and it was therefore not 
trivially possible to change the parameter order of a function (or to 
omit a parameter completely). With closures, this is now possible 
without any problems.

Converting the method so that it works like `array_filter` would mean 
that we would have to introduce new constants (or inconsistent, too: an 
enum) for the function that controls this behaviour. Reusing the 
constants which are used in `array_filter` is not possible, because the 
constant name contains the function name `array_filter`.

Cheers

Josh