Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123023
Message-ID: <45b726f4-8085-43e2-b701-6b35bc249409@wcflabs.de>
Date: Sun, 7 Apr 2024 21:10:19 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] RFC [Discussion]: array_find
Content-Language: de-DE
References: <24e4529d-0b75-44de-90ef-34de5dfb1c99@wcflabs.de>
 <278889be-82ab-4827-a9e7-801b5ba2d8f8@app.fastmail.com>
To: Larry Garfield <larry@garfieldtech.com>,
 PHP internals <internals@lists.php.net>
In-Reply-To: <278889be-82ab-4827-a9e7-801b5ba2d8f8@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: josh@wcflabs.de ("=?UTF-8?Q?Joshua_R=C3=BCsweg?=")

Hi

On 07.04.24 16:35, Larry Garfield wrote:
> 1. Should this work on arrays or iterables?  This is a long standing limitation of PHP.  The array operations don't work on iterables, even though we've had iterables for 20 years.)

In the longer term, it definitely makes sense to create a separate API 
here that can handle not only arrays, but iterables in general. I have 
heard this suggestion in various places (including in the mailing list) 
and had also looked into it in the process of this RFC, but did not 
pursue it further after the initial idea, as it would be important for 
me that such an API is planned accordingly and has an appropriate 
repertoire right from the start (functions such as map, filter, find, 
push, pop, …). In my opinion, a single function would be very out of 
place, especially if this API is then really soon tackled and then 
possibly differs from the implementation of the RFC.

> 2. Key handling.  It's good that you have looked into this, because I was going to mention it. :-)  However, I don't think a boolean is the right answer, since the question is binary, not true/false.  (Those are not the same thing.)  I think a small return-mode Enum would make more sense here.

I like the idea, thank you! However, I am unsure whether an additional 
enum for the function would not be too much overhead.

Cheers

Joshua Rüsweg